sk0x50 commented on code in PR #5621:
URL: https://github.com/apache/ignite-3/pull/5621#discussion_r2046734437
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java:
##########
@@ -66,6 +67,14 @@ public class CatalogUtils {
*/
public static final String DEFAULT_FILTER = "$..*";
+ /**
+ * Default auto adjust scale up timeout of the default zone.
+ */
+ // In case of enabled colocation the start of each node triggers default
zone rebalance. In order to eliminate such excessive rebalances
+ // default zone auto adjust scale up timeout is set to 5 seconds. If
colocation is disabled tests usually create tables
+ // after all nodes already started meaning that tables are created on
stable topology and usually doesn't assume any rebalances at all.
+ public static final int
DEFAULT_ZONE_DEFAULT_AUTO_ADJUST_SCALE_UP_TIMEOUT_SECONDS = enabledColocation()
? 5 : 0;
Review Comment:
Just my two cents, in general, such an approach might be a problem. Let's
consider a simple test:
```
public class Test {
@WithSystemProperty(key = COLOCATION_FEATURE_FLAG, value = "false")
public vois testPartitionPerTable() {...}
@WithSystemProperty(key = COLOCATION_FEATURE_FLAG, value = "true")
public vois testPartitionPerZone() {...}
}
```
In that case, the value of
`DEFAULT_ZONE_DEFAULT_AUTO_ADJUST_SCALE_UP_TIMEOUT_SECONDS` will depend on the
test order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
