AMashenkov commented on code in PR #5662:
URL: https://github.com/apache/ignite-3/pull/5662#discussion_r2053522080
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/IgniteTypeFactory.java:
##########
@@ -114,22 +116,7 @@ public IgniteTypeFactory(RelDataTypeSystem typeSystem) {
charset = StandardCharsets.UTF_8;
}
- // IgniteCustomType: all custom data types are registered here
- NewCustomType uuidType = new NewCustomType(UuidType.SPEC, (nullable,
precision) -> new UuidType(nullable));
- // UUID type can be converted from character types.
- uuidType.addCoercionRules(SqlTypeName.CHAR_TYPES);
-
- customDataTypes = new CustomDataTypes(Set.of(uuidType));
- }
-
- /** {@inheritDoc} */
- @Override
- public RelDataType createSqlType(SqlTypeName typeName) {
- if (typeName == SqlTypeName.UUID) {
- return createCustomType(UuidType.NAME);
- } else {
- return super.createSqlType(typeName);
- }
+ customDataTypes = new CustomDataTypes(Set.of());
Review Comment:
Should we drop CustomDataTypes class?
And
org.apache.ignite.internal.sql.engine.util.SafeCustomTypeInternalConversion ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
