rpuch commented on code in PR #5664:
URL: https://github.com/apache/ignite-3/pull/5664#discussion_r2054205812
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ZoneResourcesManager.java:
##########
@@ -182,6 +182,10 @@ void destroyZonePartitionResources(ZonePartitionId
zonePartitionId) {
CompletableFuture<Void> removeTableResources(ZonePartitionId
zonePartitionId, int tableId) {
ZonePartitionResources resources =
getZonePartitionResources(zonePartitionId);
+ if (resources == null) {
+ return CompletableFuture.completedFuture(null);
Review Comment:
```suggestion
return nullCompletedFuture();
```
##########
modules/low-watermark/src/main/java/org/apache/ignite/internal/lowwatermark/LowWatermarkImpl.java:
##########
@@ -234,18 +234,12 @@ HybridTimestamp createNewLowWatermarkCandidate() {
}
private void setLowWatermark(HybridTimestamp newLowWatermark) {
- updateLowWatermarkLock.writeLock().lock();
Review Comment:
Why is protection with the write lock removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
