ibessonov commented on code in PR #5670:
URL: https://github.com/apache/ignite-3/pull/5670#discussion_r2054577477


##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -262,12 +272,11 @@ private enum RecoveryStatus {
     /**
      * Write options used to write to RocksDB.
      *
-     * <p>Access is guarded by {@link #rwLock}.
+     * <p>Metastorage recovery is based on the snapshot & external log. WAL is 
never used for recovery, and can be safely disabled.
      */
-    private WriteOptions writeOptions;
+    private static final WriteOptions WRITE_OPTIONS = new 
WriteOptions().setDisableWAL(true);

Review Comment:
   Not a big deal. I can rollback this change actually, it's kind of irrelevant 
to this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to