Cyrill commented on code in PR #5694:
URL: https://github.com/apache/ignite-3/pull/5694#discussion_r2059991829
##########
modules/rest-api/src/main/java/org/apache/ignite/internal/rest/api/recovery/DisasterRecoveryApi.java:
##########
@@ -105,4 +105,69 @@ CompletableFuture<GlobalPartitionStatesResponse>
getGlobalPartitionStates(
@Consumes(MediaType.APPLICATION_JSON)
@Produces(MediaType.PROBLEM_JSON)
CompletableFuture<Void> restartPartitions(@Body RestartPartitionsRequest
command);
+
+ @Post("zone/partitions/reset")
+ @Operation(
+ operationId = "resetZonePartitions",
+ description = "Updates assignments of zone's partitions in a
forced manner, allowing for the recovery of raft groups with "
+ + "lost majorities."
+ )
+ @ApiResponse(responseCode = "200", description = "Partition states reset.")
+ @ApiResponse(responseCode = "500", description = "Internal error.",
+ content = @Content(mediaType = MediaType.PROBLEM_JSON, schema =
@Schema(implementation = Problem.class)))
+ @ApiResponse(responseCode = "400", description = "Bad request.",
+ content = @Content(mediaType = MediaType.PROBLEM_JSON, schema =
@Schema(implementation = Problem.class)))
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.PROBLEM_JSON)
+ CompletableFuture<Void> resetZonePartitions(@Body
ResetZonePartitionsRequest command);
Review Comment:
DisasterRecoveryManager has "Table" in all its methods that work with
TablePartitionId, while here we have the opposite. Can we stick to either way
that looks consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
