Copilot commented on code in PR #5736:
URL: https://github.com/apache/ignite-3/pull/5736#discussion_r2071240328
##########
modules/compute/src/main/java/org/apache/ignite/internal/compute/executor/ComputeExecutorImpl.java:
##########
@@ -133,7 +133,7 @@ private Callable<CompletableFuture<ComputeJobDataHolder>>
getJobCallable(
// TODO IGNITE-25116: Remove.
if (jobClassName.startsWith("TEST_ONLY_DOTNET_JOB:") && dotNetExec0 !=
null) {
- return
dotNetExec0.getJobCallable(getDeploymentUnitPaths(classLoader), jobClassName,
input, context);
+ return
dotNetExec0.getJobCallable(getDeploymentUnitPaths(classLoader),
jobClassName.substring(21), input, context);
Review Comment:
The use of a hard-coded index '21' for removing the job prefix may be
fragile. Consider defining a constant for the prefix length or the prefix
string to improve clarity and maintainability.
##########
modules/platforms/dotnet/Apache.Ignite/Compute/IComputeJob.cs:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Compute;
+
+using System.Threading;
+using System.Threading.Tasks;
+using Marshalling;
+
+/// <summary>
+/// Ignite compute job interface.
+/// <para />
+/// To define a compute job, implement this interface and deploy the binaries
to the cluster with the Deployemnt API.
Review Comment:
The word 'Deployemnt' appears to be a typo. Consider correcting it to
'Deployment'.
```suggestion
/// To define a compute job, implement this interface and deploy the
binaries to the cluster with the Deployment API.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
