Copilot commented on code in PR #5739:
URL: https://github.com/apache/ignite-3/pull/5739#discussion_r2071436296
##########
modules/platforms/dotnet/Apache.Ignite/Internal/Transactions/LazyTransaction.cs:
##########
@@ -105,6 +105,9 @@ public async Task RollbackAsync()
/// <inheritdoc/>
public async ValueTask DisposeAsync() => await
RollbackAsync().ConfigureAwait(false);
+ /// <inheritdoc/>
Review Comment:
[nitpick] Consider adding a comment to clarify that synchronous disposal is
implemented by blocking on DisposeAsync, and note that this behavior is
intended in contexts where blocking is acceptable.
```suggestion
/// <inheritdoc/>
// Synchronously disposes the transaction by blocking on DisposeAsync.
// This behavior is intentional and acceptable in contexts where
blocking is permissible.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
