tkalkirill commented on code in PR #5759:
URL: https://github.com/apache/ignite-3/pull/5759#discussion_r2075538795
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/storage/state/rocksdb/TxStateRocksDbStorage.java:
##########
@@ -160,7 +160,7 @@ public void destroy() {
sharedStorage.db().deleteRange(start, end);
} catch (Exception e) {
- throw new IgniteInternalException("Failed to destroy the
transaction state storage of the table: " + id, e);
+ throw new TxStateStorageException("Failed to destroy the
transaction state storage of the table: " + id, e);
Review Comment:
Same
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/storage/state/rocksdb/TxStateRocksDbStorage.java:
##########
@@ -146,7 +146,7 @@ public void close() {
reverse(resources);
closeAll(resources);
} catch (Exception e) {
- throw new IgniteInternalException("Failed to stop transaction
state storage of the table: " + id, e);
+ throw new TxStateStorageException("Failed to stop transaction
state storage of the table: " + id, e);
Review Comment:
Optional, I would do something like this: `throw new
TxStateStorageException("Failed to stop transaction state storage of the table:
{}", e, id);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
