valepakh commented on code in PR #5685:
URL: https://github.com/apache/ignite-3/pull/5685#discussion_r2077379360
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogZoneDescriptor.java:
##########
@@ -151,6 +160,20 @@ public int replicas() {
return replicas;
}
+ /**
+ * Return quorum size.
+ */
Review Comment:
Added some javadocs here and there.
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterZoneCommandBuilder.java:
##########
@@ -46,6 +46,14 @@ public interface AlterZoneCommandBuilder extends
AbstractZoneCommandBuilder<Alte
*/
AlterZoneCommandBuilder replicas(@Nullable Integer replicas);
+ /**
+ * Sets the quorum size.
+ *
+ * @param quorumSize Optional quorum size, it should be in the range from
1 to the {@code Math.floor((replicas + 1)/2) }.
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
