vldpyatkov commented on code in PR #5779:
URL: https://github.com/apache/ignite-3/pull/5779#discussion_r2080108755
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/PlacementDriverManager.java:
##########
@@ -263,9 +263,11 @@ private void takeOverActiveActorBusy() {
/** Steps down as active actor. */
private void stepDownActiveActorBusy() {
- LOG.info("Placement driver active actor is stopping.");
+ if (leaseUpdater.active()) {
Review Comment:
Not worth checking state here because we are already checking the state in
method active. Had better move the log message into the critical section of
LeaseUpdate.
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -574,6 +574,7 @@ private void updateLeaseBatchInternal() {
if (clockService.before(lease.getExpirationTime(), currentTime)
&&
!groupsAmongCurrentStableAndPendingAssignments.contains(groupId)) {
iter.remove();
+
leaseNegotiator.cancelAgreement(lease.replicationGroupId());
Review Comment:
```suggestion
leaseNegotiator.cancelAgreement(groupId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
