xtern commented on code in PR #5750:
URL: https://github.com/apache/ignite-3/pull/5750#discussion_r2080988254
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java:
##########
@@ -543,6 +550,32 @@ public static Object consumeFirstArgument(Object args0,
Object args1) {
return args1;
}
+ /** Converts timestamp string into a timestamp with local time zone. */
+ public static @Nullable Long toTimestampWithLocalTimeZone(@Nullable String
v, TimeZone timeZone) {
Review Comment:
I still don't get the idea. In the test we use a method that ignite itself
doesn't use. Ignite uses the calcite method.
In any case, if ignite itself doesn't use this method, or it doesn't change
the behavior of the original calcite method, it shouldn't be added, in my
opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
