Vladsz83 commented on code in PR #12085:
URL: https://github.com/apache/ignite/pull/12085#discussion_r2120867464
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/IgniteSqlCallRewriteTable.java:
##########
@@ -76,6 +89,10 @@ private static SqlCall nvlRewriter(SqlValidator validator,
SqlCall call) {
if (operands.size() == 2) {
SqlParserPos pos = call.getParserPosition();
+ // Do not rewrite to CASE-WHEN calls that contain subqueries.
Review Comment:
I think a TODO with a ticket link is better here too.
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/CalciteQueryProcessor.java:
##########
@@ -174,6 +174,8 @@ public class CalciteQueryProcessor extends
GridProcessorAdapter implements Query
.withLex(Lex.ORACLE)
.withConformance(IgniteSqlConformance.INSTANCE))
.sqlValidatorConfig(SqlValidator.Config.DEFAULT
+ // TODO Workaround for
https://issues.apache.org/jira/browse/CALCITE-6978
+ .withCallRewrite(false)
Review Comment:
We can also remove no-call-rewrite config from
`testFunctionArgsToNumericImplicitConversion()`. Or keep for future fixes. Up
to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
