sashapolo commented on code in PR #5993:
URL: https://github.com/apache/ignite-3/pull/5993#discussion_r2131838018
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -1465,6 +1465,8 @@ private CompletableFuture<Void> changePeersOnRebalance(
.exceptionally(e -> null);
});
}));
+
+ return nullCompletedFuture();
Review Comment:
Why do we return a future from this method?
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -1465,6 +1465,8 @@ private CompletableFuture<Void> changePeersOnRebalance(
.exceptionally(e -> null);
Review Comment:
We skip exceptions here and also do not log anything in outer `thenCompose`
methods, I find this suspicious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
