rpuch commented on code in PR #5997:
URL: https://github.com/apache/ignite-3/pull/5997#discussion_r2131988829
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/index/IndexMetaStorage.java:
##########
@@ -360,18 +365,27 @@ private CompletableFuture<Void> recoverIndexMetas() {
}
// Let's identify the indexes that were removed from the catalog
in this version.
+ Set<Integer> knownRemovedIndexIds = new HashSet<>();
Review Comment:
We can, but this way it makes it more difficult to understand the code
because `indexIds` collected before the internal loop only contains
'from-catalog' indices, but now we suddenly add 'not-from-catalog' indices to
them. This looks pretty confusing even for me who just grokked the code; for
others it will be even more confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
