vldpyatkov commented on code in PR #5915:
URL: https://github.com/apache/ignite-3/pull/5915#discussion_r2142552232
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/WriteIntentSwitchProcessor.java:
##########
@@ -92,8 +92,9 @@ public CompletableFuture<WriteIntentSwitchReplicatedInfo>
switchWriteIntentsWith
if (ex != null) {
Throwable cause = ExceptionUtils.unwrapCause(ex);
- if (TransactionFailureHandler.isRecoverable(cause)) {
- LOG.info("Failed to switch write intents for Tx.
The operation will be retried [txId={}].", txId, ex);
Review Comment:
We probably shouldn't log this every time here.
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##########
@@ -815,8 +811,10 @@ private CompletableFuture<Void> durableFinish(
return CompletableFuture.<Void>failedFuture(cause);
}
- if (TransactionFailureHandler.isRecoverable(cause)) {
- LOG.warn("Failed to finish Tx. The operation will
be retried [txId={}].", ex, txId);
+ if
(ReplicatorRecoverableExceptions.isRecoverable(cause)) {
+ if (!(cause instanceof GroupOverloadedException)) {
+ LOG.warn("Failed to finish Tx. The operation
will be retried [txId={}].", ex, txId);
Review Comment:
Are you sure this should be logged here? These messages flood the log file
during overloads.
##########
modules/cluster-management/src/integrationTest/java/org/apache/ignite/internal/cluster/management/raft/ItCmgRaftServiceTest.java:
##########
@@ -146,7 +146,7 @@ void afterNodeStart() {
RaftGroupService raftService;
if (serverPeer == null) {
- raftService =
raftManager.startRaftGroupService(CmgGroupId.INSTANCE, configuration);
+ raftService =
raftManager.startRaftGroupService(CmgGroupId.INSTANCE, configuration, true);
Review Comment:
The boolean parameter will never be calculated. It would probably be better
to create a specific method to start the system RAFT client, similar to how it
was done for the system RAFT node.
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java:
##########
@@ -163,6 +176,16 @@ public Loza(
this.opts = options;
+ double maxInflightOverflowRate = IgniteSystemProperties.getDouble(
Review Comment:
I believe we already agreed to avoid using JVM properties for configuration.
RaftConfigurationSchema would be a suitable place for this property instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
