ibessonov commented on code in PR #6042:
URL: https://github.com/apache/ignite-3/pull/6042#discussion_r2149903253
##########
modules/network/src/main/java/org/apache/ignite/internal/network/MulticastNodeFinder.java:
##########
@@ -246,65 +245,95 @@ public void close() {
@Override
public void start() {
listenerThreadPool.submit(() -> {
- List<MulticastSocket> sockets = new ArrayList<>();
+ List<MulticastSocket> sockets;
- try {
- for (NetworkInterface networkInterface :
getEligibleNetworkInterfaces()) {
- MulticastSocket socket = new
MulticastSocket(multicastPort);
- configureSocket(socket, networkInterface,
POLLING_TIMEOUT_MILLIS);
- socket.joinGroup(multicastSocketAddress, networkInterface);
+ sockets = configureListenerMulticastSockets();
- sockets.add(socket);
- }
+ if (sockets.isEmpty()) {
+ LOG.error("No interfaces eligible for multicast found,
quitting.");
+ return;
+ }
- if (sockets.isEmpty()) {
- LOG.warn("No interfaces eligible for multicast found;
listener not started.");
- return;
- }
+ byte[] responseData = ByteUtils.toBytes(localAddressToAdvertise);
+ byte[] requestBuffer = new byte[REQUEST_MESSAGE.length];
- byte[] responseData =
ByteUtils.toBytes(localAddressToAdvertise);
- byte[] requestBuffer = new byte[REQUEST_MESSAGE.length];
- while (!stopped) {
- for (MulticastSocket socket : sockets) {
- DatagramPacket requestPacket = new
DatagramPacket(requestBuffer, requestBuffer.length);
- try {
- socket.receive(requestPacket);
-
- byte[] received = Arrays.copyOfRange(
- requestPacket.getData(),
- requestPacket.getOffset(),
- requestPacket.getOffset() +
requestPacket.getLength()
- );
-
- if (!Arrays.equals(received, REQUEST_MESSAGE)) {
- LOG.error("Received unexpected request on
multicast socket");
- continue;
- }
-
- DatagramPacket responsePacket = new DatagramPacket(
- responseData,
- responseData.length,
- requestPacket.getAddress(),
- requestPacket.getPort()
- );
-
- socket.send(responsePacket);
- } catch (SocketTimeoutException ignored) {
- // Timeout to check another socket.
+ while (!stopped) {
Review Comment:
Could you please comment this code? I don't understand it
##########
modules/network/src/main/java/org/apache/ignite/internal/network/MulticastNodeFinder.java:
##########
@@ -246,65 +245,95 @@ public void close() {
@Override
public void start() {
listenerThreadPool.submit(() -> {
- List<MulticastSocket> sockets = new ArrayList<>();
+ List<MulticastSocket> sockets;
- try {
- for (NetworkInterface networkInterface :
getEligibleNetworkInterfaces()) {
- MulticastSocket socket = new
MulticastSocket(multicastPort);
- configureSocket(socket, networkInterface,
POLLING_TIMEOUT_MILLIS);
- socket.joinGroup(multicastSocketAddress, networkInterface);
+ sockets = configureListenerMulticastSockets();
Review Comment:
Please join these two lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
