timoninmaxim commented on code in PR #12185:
URL: https://github.com/apache/ignite/pull/12185#discussion_r2209543601
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheInvokeDirectResult.java:
##########
@@ -34,9 +34,6 @@
*
*/
public class CacheInvokeDirectResult implements Message {
Review Comment:
This class contains transient field. Let's keep Serializable for a while.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/encryption/GridEncryptionManager.java:
##########
@@ -1307,7 +1307,7 @@ private void writeGroupKeysToMetaStore(int grpId,
List<GroupKeyEncrypted> keys)
ctx.cache().context().database().checkpointReadLock();
try {
- metaStorage.write(ENCRYPTION_KEYS_PREFIX + grpId,
(Serializable)keys);
Review Comment:
You must not change API of the MetaStorage
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/stat/IgniteStatisticsPersistenceStoreImpl.java:
##########
@@ -630,7 +630,7 @@ private boolean checkMetastore(String msg, Object... args) {
* @param obj Object to write.
* @throws IgniteCheckedException Throws in case of errors.
*/
- private void writeMeta(String key, Serializable obj) throws
IgniteCheckedException {
+ private void writeMeta(String key, Object obj) throws
IgniteCheckedException {
Review Comment:
same
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java:
##########
@@ -235,7 +235,7 @@
* @see IgniteMessaging
* @see TransmissionHandler
*/
-public class GridIoManager extends
GridManagerAdapter<CommunicationSpi<Serializable>> {
+public class GridIoManager extends
GridManagerAdapter<CommunicationSpi<Message>> {
Review Comment:
GridIoManager is a wrapper over interface CommunicationSpi<T>. We can't use
Message here, if another CommunicationSpi is in use.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/metastorage/MetaStorage.java:
##########
@@ -409,7 +409,7 @@ private void applyCallback(
}
/** {@inheritDoc} */
- @Override public void write(@NotNull String key, @NotNull Serializable
val) throws IgniteCheckedException {
+ @Override public void write(@NotNull String key, @NotNull Object val)
throws IgniteCheckedException {
Review Comment:
You must not change API for the MetaStorage
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheSqlQuery.java:
##########
@@ -34,9 +34,6 @@
* Query.
*/
public class GridCacheSqlQuery implements Message {
Review Comment:
Contains transient fields. Let's keep it Serializable for a while
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/metastorage/persistence/ReadWriteMetaStorageMock.java:
##########
@@ -33,7 +33,7 @@ public class ReadWriteMetaStorageMock implements
ReadWriteMetastorage {
public final Map<String, byte[]> cache = new ConcurrentSkipListMap<>();
/** {@inheritDoc} */
- @Override public void write(@NotNull String key, @NotNull Serializable
val) throws IgniteCheckedException {
+ @Override public void write(@NotNull String key, @NotNull Object val)
throws IgniteCheckedException {
Review Comment:
same
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/stat/messages/StatisticsColumnData.java:
##########
@@ -25,7 +26,7 @@
/**
* Statistics by column (or by set of columns, if they collected together)
*/
-public class StatisticsColumnData implements Message {
+public class StatisticsColumnData implements Message, Serializable {
Review Comment:
Why Serializable?
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/metastorage/ReadWriteMetastorage.java:
##########
@@ -25,7 +24,7 @@
*/
public interface ReadWriteMetastorage extends ReadOnlyMetastorage {
/** */
- public void write(@NotNull String key, @NotNull Serializable val) throws
IgniteCheckedException;
+ public void write(@NotNull String key, @NotNull Object val) throws
IgniteCheckedException;
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
