ptupitsyn commented on code in PR #6280:
URL: https://github.com/apache/ignite-3/pull/6280#discussion_r2216169466
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -999,46 +999,14 @@ clockService, notificationSender(requestId)
}
}
- private static boolean isPartitionOperation(int opCode) {
- return opCode == ClientOp.TABLES_GET
- || opCode == ClientOp.TUPLE_UPSERT
- || opCode == ClientOp.TUPLE_GET
- || opCode == ClientOp.TUPLE_GET_AND_UPSERT
- || opCode == ClientOp.TUPLE_INSERT
- || opCode == ClientOp.TUPLE_REPLACE
- || opCode == ClientOp.TUPLE_REPLACE_EXACT
- || opCode == ClientOp.TUPLE_GET_AND_REPLACE
- || opCode == ClientOp.TUPLE_DELETE
- || opCode == ClientOp.TUPLE_DELETE_EXACT
- || opCode == ClientOp.TUPLE_GET_AND_DELETE
- || opCode == ClientOp.TUPLE_CONTAINS_KEY
- || opCode == ClientOp.STREAMER_BATCH_SEND
- || opCode == ClientOp.TX_COMMIT
- || opCode == ClientOp.TX_ROLLBACK;
-
- // Sql-related operation must do some bookkeeping first on the
client's thread to avoid races
- // (for instance, cancellation must not be processed until
execution request is registered).
- // || opCode == ClientOp.SQL_EXEC
- // || opCode == ClientOp.SQL_EXEC_BATCH
- // || opCode == ClientOp.SQL_EXEC_SCRIPT
- // || opCode == ClientOp.SQL_QUERY_META;
-
- // TODO: IGNITE-23641 The batch operations were excluded
because fast switching leads to performance degradation for them.
- // || opCode == ClientOp.TUPLE_UPSERT_ALL
- // || opCode == ClientOp.TUPLE_GET_ALL
- // || opCode == ClientOp.TUPLE_INSERT_ALL
- // || opCode == ClientOp.TUPLE_DELETE_ALL
- // || opCode == ClientOp.TUPLE_DELETE_ALL_EXACT
- // || opCode == ClientOp.TUPLE_CONTAINS_ALL_KEYS;
- }
-
private void processOperationInternal(
ChannelHandlerContext ctx,
ClientMessageUnpacker in,
long requestId,
int opCode
) {
CompletableFuture<ResponseWriter> fut;
+ // TODO: Dont' need atomic tracker
Review Comment:
Ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
