lowka commented on code in PR #6276:
URL: https://github.com/apache/ignite-3/pull/6276#discussion_r2218362830


##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigNode.java:
##########
@@ -350,5 +387,110 @@ static class Attributes {
         static String NAME = "name";
         static String KIND = "kind";
         static String CLASS = "class";
+        static String INSTANCE_TYPE = "instanceType";
+    }
+
+    /**
+     * Node holds a references either to a single node or to a map of possible 
polymorphic nodes with extra `base` node that 
+     * includes fields common to all polymorphic instances. Each polymorphic 
node has child nodes that represent its fields 
+     * and fields common to its polymorphic configuration as well.
+     */
+    public static class Node {
+        /**
+         * Instance type for a node that represents a `base` class of a 
polymorphic node. 
+         * A base node includes fields common to all polymorphic instances.
+         */
+        static final String BASE_INSTANCE_TYPE = "";
+
+        /**
+         * Non-polymorphic node.
+         */
+        @JsonProperty
+        private ConfigNode single;
+
+        /**
+         * All polymorphic instances.
+         */
+        @JsonProperty
+        private Map<String, ConfigNode> polymorphicNodes = new 
LinkedHashMap<>();

Review Comment:
   Thanks. Fixed.



##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigNode.java:
##########
@@ -350,5 +387,110 @@ static class Attributes {
         static String NAME = "name";
         static String KIND = "kind";
         static String CLASS = "class";
+        static String INSTANCE_TYPE = "instanceType";
+    }
+
+    /**
+     * Node holds a references either to a single node or to a map of possible 
polymorphic nodes with extra `base` node that 
+     * includes fields common to all polymorphic instances. Each polymorphic 
node has child nodes that represent its fields 
+     * and fields common to its polymorphic configuration as well.
+     */
+    public static class Node {
+        /**
+         * Instance type for a node that represents a `base` class of a 
polymorphic node. 
+         * A base node includes fields common to all polymorphic instances.
+         */
+        static final String BASE_INSTANCE_TYPE = "";
+
+        /**
+         * Non-polymorphic node.
+         */
+        @JsonProperty
+        private ConfigNode single;

Review Comment:
   Thanks. Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to