xtern commented on code in PR #6274:
URL: https://github.com/apache/ignite-3/pull/6274#discussion_r2221730953
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItTemporalIndexTest.java:
##########
@@ -68,12 +68,12 @@ static void initTestData() {
.app("CREATE TABLE DATE1 (pk DATE, val DATE, PRIMARY KEY USING
SORTED (pk));").nl()
.app("CREATE TABLE DATE2 (pk DATE, val DATE, PRIMARY KEY USING
HASH (pk));").nl()
.app("CREATE TABLE TIME1 (pk TIME, val TIME, PRIMARY KEY USING
SORTED (pk));").nl()
- .app("CREATE TABLE TIME2 (pk TIME, val TIME, PRIMARY KEY USING
HASH (pk));").nl()
+ .app("CREATE TABLE TIME2 (pk TIME(6), val TIME, PRIMARY KEY
USING HASH (pk));").nl()
Review Comment:
I added this for consistency, for example if a dynamic parameter had a
default precision of 0 (although for consistency it was probably necessary to
set precision = 9).
Anyway I think you're right, we don't need it.
Reverted this change, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
