alex-plekhanov commented on PR #12096: URL: https://github.com/apache/ignite/pull/12096#issuecomment-3113215218
@oleg-zinovev, I've partially reviewed your PR. Review not completed yet, but I have some comments to publish. Also there are a lot of codestyle violations. Please read the https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines article about Ignite codestyle. Most of the problems can be detected automatically (for example using command: ` mvn clean install -DskipTests -Dmaven.javadoc.skip=true -Pcheckstyle -T 1C`), but there are also some violated rules that currently not checked by maven, such as: - Comments should be started with an upper-case letter and ended with point - Braces should not be used for `if` one-line statements - No empty lines allowed after class declaration - Comments like `/** */` (two spaces inside) are not allowed, use one space - Abbreviation should be used for field/variables like 'value', 'group', 'buffer', ..., see full list here: https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
