alex-plekhanov commented on code in PR #313:
URL: https://github.com/apache/ignite-extensions/pull/313#discussion_r2225131241
##########
modules/performance-statistics-ext/bin/include/jvmdefaults.sh:
##########
@@ -79,23 +79,6 @@ getJavaSpecificOpts() {
current_value=$2
value=""
- if [ $version -eq 8 ] ; then
- value="\
- -XX:+AggressiveOpts \
- ${current_value}"
-
- elif [ $version -gt 8 ] && [ $version -lt 11 ]; then
- value="\
- -XX:+AggressiveOpts \
- --add-exports=java.base/jdk.internal.misc=ALL-UNNAMED \
- --add-exports=java.base/sun.nio.ch=ALL-UNNAMED \
- --add-exports=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED \
- --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED \
-
--add-exports=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED \
- --illegal-access=permit \
- --add-modules=java.xml.bind \
- ${current_value}"
-
elif [ "${version}" -ge 11 ] && [ "${version}" -lt 14 ]; then
Review Comment:
elif without if
##########
parent-internal/pom.xml:
##########
@@ -210,7 +210,7 @@
<jdk>[11,)</jdk>
Review Comment:
Do we still require this profile? Some add-opens are inherited from parent
ignite pom, but for extension there is extended list of options, but maybe some
of this options are redundant. Can you please check it on team-city (perhaps
with another PR)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
