adityamukho commented on code in PR #6299:
URL: https://github.com/apache/ignite-3/pull/6299#discussion_r2230397711
##########
modules/platforms/dotnet/Apache.Ignite.Tests/ErrorGroupTests.cs:
##########
@@ -212,7 +212,8 @@ public void TestExceptionProperties()
return groupClass
.GetFields()
- .Where(x => x.Name != "GroupCode" && x.Name !=
"GroupName" && x.Name !="ErrorPrefix")
+ .Where(x => x.Name != "GroupCode" && x.Name !=
"GroupName" && x.Name != "ErrorPrefix" &&
+
x.GetCustomAttributes(typeof(ObsoleteAttribute), false).Length == 0)
Review Comment:
This is needed to exclude aliases (by filtering out the mandatory
`[Obsolete]` tag that they must have) from the list of error codes collected
for duplicate checking. If we don't do this, aliases show up as duplicate codes
in this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
