chesnokoff commented on code in PR #12221:
URL: https://github.com/apache/ignite/pull/12221#discussion_r2234099016
##########
modules/core/src/test/java/org/apache/ignite/internal/metric/MetricsConfigurationTest.java:
##########
@@ -400,8 +400,8 @@ public void
checkOnStartAndRestart(IgniteBiInClosureX<IgniteEx, IgniteEx> afterS
afterStart.apply(g0, g1);
- g0.close();
- g1.close();
Review Comment:
Other tests that use `checkOnStartAndRestart` function are also flaky. The
problem is that the `Ignite#close` method uses `cancel == true`.
When we call `configureHistogramMetric` it uses` DmsDataWriterWorker#update`
and puts DmsTask to `updateQueue` to execute writing. When we reach `close`,
it calls `DmsDataWriterWorker#cancel` with `halt == true` and we clean the
`updateQueue` without waiting finishing the tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
