ibessonov commented on code in PR #6316:
URL: https://github.com/apache/ignite-3/pull/6316#discussion_r2236660524
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTupleComparatorUtils.java:
##########
@@ -94,7 +94,7 @@ static int compareFieldValue(
}
}
- static boolean isFlagSet(ByteBuffer tuple, int flag) {
+ public static boolean isFlagSet(ByteBuffer tuple, int flag) {
Review Comment:
The flag and the mask are the same thing here. Do we associate a `flag` with
its position, not its bit?
Anyway, if we want to rename it, we should probably do it everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
