rpuch commented on code in PR #6370:
URL: https://github.com/apache/ignite-3/pull/6370#discussion_r2263259843
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -467,23 +467,14 @@ private void handshake(ChannelHandlerContext ctx,
ClientMessageUnpacker unpacker
AuthenticationRequest<?, ?> authReq =
createAuthenticationRequest(clientHandshakeExtensions);
-
handshakeEventLoopSwitcher.switchEventLoopIfNeeded(channelHandlerContext.channel()).whenComplete((unused,
throwable) -> {
- if (throwable != null) {
- handshakeError(ctx, packer, throwable);
-
- return;
- }
-
-
authenticationManager.authenticateAsync(authReq).handleAsync((user, err) -> {
- if (err != null) {
- handshakeError(ctx, packer, err);
- } else {
- handshakeSuccess(ctx, packer, user, clientFeatures,
clientVer, clientCode);
- }
-
- return null;
- }, ctx.executor());
- });
+
handshakeEventLoopSwitcher.switchEventLoopIfNeeded(channelHandlerContext.channel())
Review Comment:
If an exception happens during switching, it will not be handled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
