lowka commented on code in PR #6374:
URL: https://github.com/apache/ignite-3/pull/6374#discussion_r2272425477
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPrunerImpl.java:
##########
@@ -38,52 +38,53 @@ public class PartitionPrunerImpl implements PartitionPruner
{
@Override
public List<MappedFragment> apply(
List<MappedFragment> mappedFragments,
- Object[] dynamicParameters
+ Object[] dynamicParameters,
+ PartitionPruningMetadata metadata
) {
+ if (metadata.data().isEmpty()) {
+ return mappedFragments;
+ }
+
List<MappedFragment> updatedFragments = new
ArrayList<>(mappedFragments.size());
Long2ObjectMap<List<String>> newNodesByExchangeId = new
Long2ObjectArrayMap<>();
// Partition pruning (PP). For each fragment:
//
- // 1. Extract PP metadata from each fragment's root in the form of
[colo_col1=<val>, ..] (see PartitionPruningMetadataExtractor)
- //
- // 2. If PP metadata exists then update fragment's colocation group
+ // If PP metadata exists then update fragment's colocation group
// to retain partition that are necessary to perform an operator (e.g.
for a scan operator such
// partitions only include that ones that can contain data).
//
// Iterate over fragments again to update fragments that receive data
from fragments updated at step 2.
Review Comment:
Partition pruning is still being done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
