JAkutenshi commented on code in PR #6389:
URL: https://github.com/apache/ignite-3/pull/6389#discussion_r2276628449
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -1103,12 +1113,21 @@ private void
sendSafeTimeSyncIfReplicaReady(CompletableFuture<Replica> replicaFu
Replica replica = replicaFuture.join();
+ ReplicationGroupId replicaGroupId = replica.groupId();
+
ReplicaSafeTimeSyncRequest req =
REPLICA_MESSAGES_FACTORY.replicaSafeTimeSyncRequest()
- .groupId(toReplicationGroupIdMessage(replica.groupId()))
+ .groupId(toReplicationGroupIdMessage(replicaGroupId))
.build();
replica.processRequest(req, localNodeId).whenComplete((res, ex) -> {
if (ex != null) {
+ if (hasCause(ex, TimeoutException.class,
ReplicationTimeoutException.class)) {
Review Comment:
We already have replica above with future's join, so I don't see how the
exception may arises
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
