sashapolo commented on code in PR #6478:
URL: https://github.com/apache/ignite-3/pull/6478#discussion_r2300428794
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterInitializer.java:
##########
@@ -292,7 +293,7 @@ private CompletableFuture<Void>
invokeMessage(Collection<ClusterNode> nodes, Net
var errorResponse = (InitErrorMessage)
response;
throw new InternalInitException(
- String.format("Got error response from
node \"%s\": %s", node.name(), errorResponse.cause()),
+
Optional.ofNullable(errorResponse.cause()).orElse(""),
Review Comment:
1. Why do we need this `ofNullable` stuff?
2. I think having the target node name in the logs would be useful, I think
we should add a logging message at least.
3. Some lines below there's a `Unexpected response from node` message,
should we fix it as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
