sergey-chugunov-1985 commented on code in PR #12297:
URL: https://github.com/apache/ignite/pull/12297#discussion_r2322143066
##########
modules/core/src/main/java/org/apache/ignite/internal/direct/stream/DirectByteBufferStream.java:
##########
@@ -312,11 +320,39 @@ public class DirectByteBufferStream {
/** */
private int topVerMinor;
+ /** */
+ private byte cacheObjState;
Review Comment:
I suggest to rename this to `cacheObjRWState` and provide the following
javadoc: `This field represents a phase of reading or writing CacheObject
object enabling ser/des mechanism to keep track of fields that are already
read/written.
##########
modules/core/src/main/java/org/apache/ignite/internal/direct/DirectMessageReader.java:
##########
@@ -50,10 +53,10 @@ public class DirectMessageReader implements MessageReader {
/**
* @param msgFactory Message factory.
*/
- public DirectMessageReader(final MessageFactory msgFactory) {
+ public DirectMessageReader(final MessageFactory msgFactory,
IgniteCacheObjectProcessor cacheObjProc) {
Review Comment:
Please add new parameter description to javadoc.
##########
modules/core/src/main/java/org/apache/ignite/internal/direct/DirectMessageReader.java:
##########
@@ -386,8 +411,8 @@ private static class StateItem implements
DirectMessageStateItem {
/**
* @param msgFactory Message factory.
*/
- public StateItem(MessageFactory msgFactory) {
- stream = new DirectByteBufferStream(msgFactory);
+ public StateItem(MessageFactory msgFactory, IgniteCacheObjectProcessor
cacheObjProc) {
Review Comment:
Please add new parameter description to javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
