Copilot commented on code in PR #6582:
URL: https://github.com/apache/ignite-3/pull/6582#discussion_r2343745624
##########
modules/platforms/cpp/ignite/common/detail/bytes.h:
##########
@@ -79,9 +83,9 @@ namespace ignite::detail {
*/
enum class endian {
#if IGNITE_STD_ENDIAN
- LITTLE = std::endian::little,
- BIG = std::endian::big,
- NATIVE = std::endian::native,
+ LITTLE = static_cast<std::underlying_type_t<endian>>(std::endian::little),
+ BIG = static_cast<std::underlying_type_t<endian>>(std::endian::big),
+ NATIVE = static_cast<std::underlying_type_t<endian>>(std::endian::native),
Review Comment:
The cast to `std::underlying_type_t<endian>` creates a circular dependency
since `endian` is the type being defined. This will likely cause compilation
errors. Consider using a specific integer type like `int` or defining the enum
values as plain integers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
