korlov42 commented on code in PR #6599:
URL: https://github.com/apache/ignite-3/pull/6599#discussion_r2355258854
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java:
##########
@@ -365,6 +365,11 @@ private CompletableFuture<CatalogCommand>
convertCreateTable(IgniteSqlCreateTabl
}
IgniteSqlPrimaryKeyConstraint pkConstraint = pkConstraints.get(0);
+ String pkName = null;
+ SqlIdentifier pkIdentifier = pkConstraint.getName();
+ if (pkIdentifier != null) {
+ pkName = deriveObjectName(pkIdentifier, ctx, "name of pk
constraint");
+ }
Review Comment:
only because such change requires to touch _a lot_ of tests. Also, this will
make `CreateTableCommandBuilder` less re-usable (again, only tests are
affected) because after this it will be not enough just to set another
tableName to create similar table, you also will be needed to change key
definition to avoid name collisions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
