xtern commented on code in PR #6563:
URL: https://github.com/apache/ignite-3/pull/6563#discussion_r2336838190
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/StorageUpdateHandler.java:
##########
@@ -132,6 +138,8 @@ public void handleUpdate(
if (trackWriteIntent) {
pendingRows.addPendingRowId(txId, rowId);
+ } else if (commitTs != null) {
+ modificationCounter.updateValue(1, commitTs);
Review Comment:
Thanks, It looks like you're right, but without this condition some unit
tests fail.
And they kind of test scenarios that can't be tested any other way now. It
looks like they can be reworked (with the introduction of additional testing
methods in production code).
I filed a ticket for this https://issues.apache.org/jira/browse/IGNITE-26411
And marked this if with TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
