sergey-chugunov-1985 commented on code in PR #12327:
URL: https://github.com/apache/ignite/pull/12327#discussion_r2333254804
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/CacheGroupAffinityMessage.java:
##########
@@ -240,79 +235,45 @@ private List<List<ClusterNode>>
createAssignments(List<GridLongList> assigns,
}
/**
- * @return Difference with ideal affinity assignment.
+ * @return Assignment.
*/
- public Map<Integer, GridLongList> assignmentsDiff() {
- return assignsDiff;
+ public List<GridLongList> assigns() {
Review Comment:
I would suggest to rename these methods to `assignments`/`idealAssignments`
and specify them in `Order` annotation's parameters.
This would be consistent with other public methods of this class: for its
public methods it doesn't use an abbreviations but full form of the word
`assignment`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
