valepakh commented on code in PR #6356:
URL: https://github.com/apache/ignite-3/pull/6356#discussion_r2371688775
##########
modules/compatibility-tests/src/integrationTest/java/org/apache/ignite/internal/ItCompatibilityTest.java:
##########
@@ -49,29 +53,59 @@ protected void
configureInitParameters(InitParametersBuilder builder) {
@Override
protected void setupBaseVersion(Ignite baseIgnite) {
- sql(baseIgnite, "CREATE TABLE TEST(ID INT PRIMARY KEY, VAL VARCHAR)");
+ sql(baseIgnite, "CREATE TABLE TEST_ALL_TYPES("
+ + "ID INT PRIMARY KEY, "
+ + "VAL_INT INT, "
+ + "VAL_BIGINT BIGINT, "
+ + "VAL_FLOAT FLOAT, "
+ + "VAL_DOUBLE DOUBLE, "
+ + "VAL_DECIMAL DECIMAL(10,2), "
+ + "VAL_BOOL BOOLEAN, "
+ + "VAL_STR VARCHAR, "
+ + "VAL_DATE DATE, "
+ + "VAL_TIME TIME, "
+ + "VAL_TIMESTAMP TIMESTAMP)");
- Transaction tx = baseIgnite.transactions().begin();
- sql(baseIgnite, tx, "INSERT INTO TEST VALUES (1, 'str')");
- tx.commit();
+ baseIgnite.transactions().runInTransaction(tx -> {
+ sql(baseIgnite, tx, "INSERT INTO TEST_ALL_TYPES VALUES (?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?)",
+ 1, 42, 1234567890123L, 3.14f, 2.71828d, new
BigDecimal("1234.56"), true,
+ "hello", LocalDate.of(2025, 7, 23), LocalTime.of(12, 34,
56), LocalDateTime.of(2025, 7, 23, 12, 34, 56));
+ });
- List<List<Object>> result = sql(baseIgnite, "SELECT * FROM TEST");
- assertThat(result, contains(contains(1, "str")));
+ List<List<Object>> result = sql(baseIgnite, "SELECT * FROM
TEST_ALL_TYPES");
+ assertThat(result, contains(contains(
+ 1, 42, 1234567890123L, 3.14f, 2.71828d, new
BigDecimal("1234.56"), true,
+ "hello", LocalDate.of(2025, 7, 23), LocalTime.of(12, 34, 56),
LocalDateTime.of(2025, 7, 23, 12, 34, 56)
+ )));
}
@Test
- void testCompatibility() {
+ void testAllTypesAndTransactions() {
// Read old data
- List<List<Object>> result = sql("SELECT * FROM TEST");
- assertThat(result, contains(contains(1, "str")));
+ List<List<Object>> result = sql("SELECT * FROM TEST_ALL_TYPES WHERE ID
= 1");
Review Comment:
```suggestion
List<List<Object>> result = sql("SELECT * FROM TEST_ALL_TYPES");
```
##########
modules/compatibility-tests/src/integrationTest/java/org/apache/ignite/internal/ItCompatibilityTest.java:
##########
@@ -21,17 +21,21 @@
import static org.hamcrest.Matchers.contains;
import static org.hamcrest.Matchers.containsInAnyOrder;
+import java.math.BigDecimal;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
import java.util.List;
import org.apache.ignite.Ignite;
import org.apache.ignite.InitParametersBuilder;
-import org.apache.ignite.tx.Transaction;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedClass;
import org.junit.jupiter.params.provider.MethodSource;
@ParameterizedClass
@MethodSource("baseVersions")
class ItCompatibilityTest extends CompatibilityTestBase {
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
