sk0x50 commented on code in PR #6645:
URL: https://github.com/apache/ignite-3/pull/6645#discussion_r2378543921
##########
modules/client/src/main/java/org/apache/ignite/internal/client/ClientMetricSource.java:
##########
@@ -30,8 +30,8 @@ public class ClientMetricSource extends
AbstractMetricSource<ClientMetricSource.
/**
* Constructor.
*/
- ClientMetricSource() {
- super("client");
+ ClientMetricSource(String name) {
Review Comment:
Nope, in your case, a client name is a part of the metric source name, and
that is not true for servers. We use an ugly method to properly set up the
`MetricManagerImpl` with a node name, see `configure` method (I hope it will be
changed in the future, but it does not matter for now). The reason for it, for
example, is that the `makeMbeanName` uses a `nodeName` in a slightly different
way, see
https://github.com/apache/ignite-3/blob/main/modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java#L1050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
