AMashenkov commented on code in PR #6648:
URL: https://github.com/apache/ignite-3/pull/6648#discussion_r2381991690
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/RenameTableEntry.java:
##########
@@ -17,23 +17,15 @@
package org.apache.ignite.internal.catalog.storage;
-import static
org.apache.ignite.internal.catalog.commands.CatalogUtils.defaultZoneIdOpt;
-import static
org.apache.ignite.internal.catalog.commands.CatalogUtils.replaceSchema;
-import static
org.apache.ignite.internal.catalog.commands.CatalogUtils.replaceTable;
-import static
org.apache.ignite.internal.catalog.commands.CatalogUtils.schemaOrThrow;
-import static
org.apache.ignite.internal.catalog.commands.CatalogUtils.tableOrThrow;
-
-import org.apache.ignite.internal.catalog.Catalog;
-import org.apache.ignite.internal.catalog.descriptors.CatalogSchemaDescriptor;
import org.apache.ignite.internal.catalog.descriptors.CatalogTableDescriptor;
+import
org.apache.ignite.internal.catalog.descriptors.CatalogTableDescriptor.Builder;
import org.apache.ignite.internal.catalog.events.CatalogEvent;
import org.apache.ignite.internal.catalog.events.CatalogEventParameters;
import org.apache.ignite.internal.catalog.events.RenameTableEventParameters;
import
org.apache.ignite.internal.catalog.storage.serialization.MarshallableEntryType;
-import org.apache.ignite.internal.hlc.HybridTimestamp;
/** Entry representing a rename of a table. */
-public class RenameTableEntry implements UpdateEntry, Fireable {
+public class RenameTableEntry implements UpdateTable, Fireable {
Review Comment:
UpdateTable bumps schema version.
I think it make no sense in this case.
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/RenameTableEntry.java:
##########
@@ -17,23 +17,15 @@
package org.apache.ignite.internal.catalog.storage;
-import static
org.apache.ignite.internal.catalog.commands.CatalogUtils.defaultZoneIdOpt;
-import static
org.apache.ignite.internal.catalog.commands.CatalogUtils.replaceSchema;
-import static
org.apache.ignite.internal.catalog.commands.CatalogUtils.replaceTable;
-import static
org.apache.ignite.internal.catalog.commands.CatalogUtils.schemaOrThrow;
-import static
org.apache.ignite.internal.catalog.commands.CatalogUtils.tableOrThrow;
-
-import org.apache.ignite.internal.catalog.Catalog;
-import org.apache.ignite.internal.catalog.descriptors.CatalogSchemaDescriptor;
import org.apache.ignite.internal.catalog.descriptors.CatalogTableDescriptor;
+import
org.apache.ignite.internal.catalog.descriptors.CatalogTableDescriptor.Builder;
import org.apache.ignite.internal.catalog.events.CatalogEvent;
import org.apache.ignite.internal.catalog.events.CatalogEventParameters;
import org.apache.ignite.internal.catalog.events.RenameTableEventParameters;
import
org.apache.ignite.internal.catalog.storage.serialization.MarshallableEntryType;
-import org.apache.ignite.internal.hlc.HybridTimestamp;
/** Entry representing a rename of a table. */
-public class RenameTableEntry implements UpdateEntry, Fireable {
+public class RenameTableEntry implements UpdateTable, Fireable {
Review Comment:
UpdateTable bumps table schema version.
I think it make no sense in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
