ivanzlenko commented on code in PR #6648: URL: https://github.com/apache/ignite-3/pull/6648#discussion_r2382571658
########## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateTable.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.catalog.storage; + +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.defaultZoneIdOpt; +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.replaceSchema; +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.replaceTable; +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.schemaOrThrow; +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.tableOrThrow; + +import org.apache.ignite.internal.catalog.Catalog; +import org.apache.ignite.internal.catalog.descriptors.CatalogSchemaDescriptor; +import org.apache.ignite.internal.catalog.descriptors.CatalogTableDescriptor; +import org.apache.ignite.internal.hlc.HybridTimestamp; + +/** + * This class declares an abstract method for creating a new table descriptor and + * provides default implementation for applying the table descriptor changes to a catalog. + */ +abstract class UpdateTable implements UpdateEntry { Review Comment: The main issue with abstract class: whenever we need to implement a class which need to implement UpdateTable and some other random interface - it will be not possible with the abstract class. And I can see the possibility that we can actually stumble upon this case sometime in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
