rpuch commented on code in PR #6696:
URL: https://github.com/apache/ignite-3/pull/6696#discussion_r2405882567
##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/CliIntegrationTest.java:
##########
@@ -69,6 +69,7 @@ public abstract class CliIntegrationTest extends
ClusterPerClassIntegrationTest
new MetricSource().name("sql.client").enabled(true),
new MetricSource().name("sql.plan.cache").enabled(true),
new MetricSource().name("sql.queries").enabled(true),
+ new MetricSource().name("storage.aipersist").enabled(true),
new MetricSource().name("storage.aipersist.default").enabled(true),
new
MetricSource().name("storage.aipersist.default_aipersist").enabled(true),
new
MetricSource().name("storage.aipersist.checkpoint").enabled(true),
Review Comment:
I think we should eliminate the possibility for a clash. One way to do it is
like this:
1. For metrics under 'engine + storage profile', we add another level after
the engine, like 'aipersist.profile.default'
2. We add our own engine metrics right under the engine, like
'aipersist.checkpoint'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
