Cyrill commented on code in PR #6711:
URL: https://github.com/apache/ignite-3/pull/6711#discussion_r2416222450
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/StorageUpdateHandler.java:
##########
@@ -121,6 +122,8 @@ public void handleUpdate(
@Nullable HybridTimestamp lastCommitTs,
@Nullable List<Integer> indexIds
) {
+ assert trackWriteIntent || commitTs != null : "either trackWriteIntent
must be true or commitTs must be non-null";
Review Comment:
I would add a comment here with the reason for such assert, that
commit ts is not null for a full transaction (one phase commit)
and trackWriteIntent is true only for a regular, 2PC transactions - needed
to switch write intents once we commit/abort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
