AMashenkov commented on code in PR #6772:
URL: https://github.com/apache/ignite-3/pull/6772#discussion_r2431946885
##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc2/JdbcConnection2.java:
##########
@@ -247,14 +261,51 @@ public String nativeSQL(String sql) throws SQLException {
return sql;
}
+ @Nullable Transaction startTransactionIfNoAutoCommit() {
+ if (transaction == null && !autoCommit) {
+ transaction = igniteClient.transactions().begin(new
TransactionOptions().readOnly(false));
+ return transaction;
+ } else {
+ return transaction;
+ }
+ }
+
+ private void finishTx(boolean commit) throws SQLException {
Review Comment:
We always pass a constant to this method.
Maybe better to have 2 ones" commit and rollback?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
