sk0x50 commented on code in PR #6730:
URL: https://github.com/apache/ignite-3/pull/6730#discussion_r2418980466
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -3329,6 +3340,13 @@ private CompletableFuture<Void> recoverTables(long
recoveryRevision, @Nullable H
tableDescriptor,
schemaDescriptor
);
+
+ if (destroyTableEventFired) {
+ // prepareTableResourcesOnRecovery registers a table
metric source, so we need to unregister it here,
+ // just because the table is being dropped and there
is no need to keep the metric source.
+ QualifiedName tableName =
QualifiedNameHelper.fromNormalized(schemaDescriptor.name(),
tableDescriptor.name());
+
metricManager.unregisterSource(TableMetricSource.sourceName(tableName));
Review Comment:
Nice catch! Will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
