ibessonov commented on code in PR #6733: URL: https://github.com/apache/ignite-3/pull/6733#discussion_r2420259869
########## modules/compatibility-tests/src/test/java/org/apache/ignite/internal/ApiCompatibilityTest.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import org.apache.ignite.internal.compatibility.api.CompatibilityChecker; +import org.apache.ignite.internal.properties.IgniteProperties; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +class ApiCompatibilityTest { + // Change to true to test compatibility between consecutive old versions + private static final boolean INCLUDE_HISTORIC_DATA = false; Review Comment: I don't really understand this flag. List of exclusions shows the difference between `main` and `3.0` for example. Using the same list of exclusions to run a check between `3.1` and `3.0` is kind of strange and inappropriate. Why do we have it here? Looks like a leftover debugging code ########## modules/compatibility-tests/src/test/java/org/apache/ignite/internal/ApiCompatibilityTest.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import org.apache.ignite.internal.compatibility.api.CompatibilityChecker; +import org.apache.ignite.internal.properties.IgniteProperties; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +class ApiCompatibilityTest { + // Change to true to test compatibility between consecutive old versions + private static final boolean INCLUDE_HISTORIC_DATA = false; + + // Map from old version to the list of excludes for the consecutive version. + // Read this as "what is broken after this version" + private static final Map<String, List<String>> EXCLUDES_PER_VERSION = Map.of( + "3.0.0", List.of( Review Comment: Old approach with an annotation didn't look that bad, we just had to replace a `String` with a `String[]`, see no issues really. But whatever, if we decided that this is the way to go then I'm OK with that too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
