timoninmaxim commented on code in PR #12376:
URL: https://github.com/apache/ignite/pull/12376#discussion_r2392150761
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java:
##########
@@ -653,24 +651,19 @@ private QueryResult<K, V> executeQuery(CacheQuery<?> qry,
* @throws IgniteCheckedException In case of error.
*/
private FieldsResult executeFieldsQuery(CacheQuery<?> qry, @Nullable
Object[] args,
- boolean loc, @Nullable String taskName, Object rcpt) throws
IgniteCheckedException {
+ boolean loc, @Nullable String
taskName, Object rcpt) throws IgniteCheckedException {
assert qry != null;
+ assert qry.type() == SQL_FIELDS : "Unexpected query type: " +
qry.type();
- FieldsResult res;
-
- T2<String, List<Object>> resKey = null;
-
- if (qry.clause() == null && qry.type() != SPI) {
+ if (qry.clause() == null) {
assert !loc;
throw new IgniteCheckedException("Received next page request after
iterator was removed. " +
- "Consider increasing maximum number of stored iterators (see "
+
- "CacheConfiguration.getMaxQueryIteratorsCount() configuration
property).");
+ "Consider increasing maximum number of stored iterators
(see " +
+ "CacheConfiguration.getMaxQueryIteratorsCount()
configuration property).");
}
-
- if (qry.type() == SQL_FIELDS) {
- if (cctx.events().isRecordable(EVT_CACHE_QUERY_EXECUTED)) {
- cctx.gridEvents().record(new CacheQueryExecutedEvent<>(
+ if (cctx.events().isRecordable(EVT_CACHE_QUERY_EXECUTED)) {
Review Comment:
add empty line before this condition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
