ibessonov commented on code in PR #6704:
URL: https://github.com/apache/ignite-3/pull/6704#discussion_r2406745532


##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogCheckpointer.java:
##########
@@ -80,6 +80,8 @@ void stop() {
 
             throw new IgniteInternalException(COMMON_ERR, "Interrupted while 
waiting for the checkpoint thread to finish.", e);
         }
+
+        queue.close();

Review Comment:
   Should it be in a `finally`? I know that `join` should not throw exceptions 
in real life, but what if



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to