AMashenkov commented on code in PR #6593:
URL: https://github.com/apache/ignite-3/pull/6593#discussion_r2405605156


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/CacheKey.java:
##########
@@ -51,14 +52,29 @@ public class CacheKey {
      *                   LOCAL flag)
      * @param paramTypes Types of all dynamic parameters, no any type can be 
{@code null}.
      */
-    public CacheKey(int catalogVersion, String schemaName, String query, 
Object contextKey, ColumnType[] paramTypes) {
+    public CacheKey(
+            int catalogVersion,
+            String schemaName,
+            String query,
+            Object contextKey,
+            ColumnType[] paramTypes,
+            SchemaPlus defaultSchema

Review Comment:
   Suggested change.
   Please, use `String schemaName` or `int schemaId` instead, to stick plan to 
a particular schema.
         
       
       
         
             
               
                           SchemaPlus defaultSchema
             
         
       
       
     
   
   Schema is not a part of the key.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to