shishkovilja commented on code in PR #12425:
URL: https://github.com/apache/ignite/pull/12425#discussion_r2445400609
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/binary/BinaryMetadataVersionInfo.java:
##########
@@ -17,36 +17,55 @@
package org.apache.ignite.internal.processors.cache.binary;
import java.io.Serializable;
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.internal.GridKernalContext;
+import org.apache.ignite.internal.Order;
import org.apache.ignite.internal.binary.BinaryMetadata;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.plugin.extensions.communication.Message;
/**
* Wrapper for {@link BinaryMetadata} which is stored in metadata local cache
on each node.
* Used internally to track version counters (see javadoc for {@link
MetadataUpdateProposedMessage} for more details).
* The version refers solely to the internal protocol for updating
BinaryMetadata and is unknown externally.
* It can be updated dynamically from different nodes and threads on the same
node.
*/
-final class BinaryMetadataVersionInfo implements Serializable {
+public final class BinaryMetadataVersionInfo implements Serializable, Message {
+ /** Type code. */
+ public static final short TYPE_CODE = 505;
+
/** */
private static final long serialVersionUID = 0L;
/** The actual binary metadata. */
- private final BinaryMetadata metadata;
+ private BinaryMetadata metadata;
+
+ /** Serialized binary metadata. */
+ @Order(0)
+ private byte[] metadataBytes;
/**
* The version of metadata that has been proposed for update. This
represents how many unique updates have been issued
* for this type. When a metadata update is proposed, this version is
incremented.
*/
- private final int pendingVer;
+ @Order(value = 1, method = "pendingVersion")
+ private int pendingVer;
/**
* The version of metadata that has been accepted by the entire cluster.
* This represents the number of updates that have been confirmed across
all nodes.
*/
- private final int acceptedVer;
+ @Order(value = 2, method = "acceptedVersion")
+ private int acceptedVer;
/** A flag indicating whether the metadata is currently being removed. */
private final transient boolean removing;
+ /** Constructor. */
+ public BinaryMetadataVersionInfo() {
+ removing = false;
Review Comment:
Let's remove, false by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
