sashapolo commented on code in PR #6815:
URL: https://github.com/apache/ignite-3/pull/6815#discussion_r2447039619
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -613,6 +613,29 @@ private <R extends NetworkMessage> CompletableFuture<R>
sendWithRetry(
Supplier<String> originDescription,
Function<Peer, ? extends NetworkMessage> requestFactory,
boolean throttleOnOverload
+ ) {
+ return sendWithRetry(peer, timeoutMillis, -1, originDescription,
requestFactory, throttleOnOverload);
+ }
+
+ /**
+ * Sends a request with retry until success or a timeout.
+ *
+ * @param peer Target peer to which the request will be sent.
+ * @param timeoutMillis Timeout for entire request sending (with retries)
in milliseconds, a negative value means no timeout.
Review Comment:
Maybe we should rename `timeoutMillis` to `sendWithRetryTimeout` and
`responseTimeoutMillis` to `singleRequestTimeout`? The current naming is very
confusing
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -613,6 +613,29 @@ private <R extends NetworkMessage> CompletableFuture<R>
sendWithRetry(
Supplier<String> originDescription,
Function<Peer, ? extends NetworkMessage> requestFactory,
boolean throttleOnOverload
+ ) {
+ return sendWithRetry(peer, timeoutMillis, -1, originDescription,
requestFactory, throttleOnOverload);
+ }
+
+ /**
+ * Sends a request with retry until success or a timeout.
Review Comment:
```suggestion
* Sends a request with retry until success or reaches a timeout.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
