JAkutenshi commented on code in PR #6712:
URL: https://github.com/apache/ignite-3/pull/6712#discussion_r2452802650
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/systemviews/ItZonesSystemViewTest.java:
##########
@@ -165,22 +169,22 @@ public void systemViewRenameCustomZone() {
DEFAULT_CONSISTENCY_MODE.name()
).check();
- assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(2L).check();
+ assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(1L).check();
sql("DROP ZONE " + ALTER_ZONE_NAME);
}
@Test
public void systemViewDropCustomZone() {
- assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(1L).check();
+ assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(0L).check();
sql(createZoneSql(ZONE_NAME, 1, 5, 2, 3, 4, DEFAULT_FILTER));
- assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(2L).check();
+ assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(1L).check();
sql("DROP ZONE " + ZONE_NAME);
- assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(1L).check();
+ assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(0L).check();
}
Review Comment:
Added new `testDefaultZoneCreationIsIdempotent` but it's catalog commands
tests. I guess it should be enough and it's not the case for system view test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
