AMashenkov commented on code in PR #6649:
URL: https://github.com/apache/ignite-3/pull/6649#discussion_r2464907953
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/statistic/SqlStatisticManagerImpl.java:
##########
@@ -69,15 +74,30 @@ public class SqlStatisticManagerImpl implements
SqlStatisticUpdateManager {
private final AtomicReference<StatisticUpdatesSupplier> changesSupplier =
new AtomicReference<>();
/* Contains all known table id's with statistics. */
- private final ConcurrentMap<Integer, ActualSize> tableSizeMap = new
ConcurrentHashMap<>();
+ final ConcurrentMap<Integer, ActualSize> tableSizeMap = new
ConcurrentHashMap<>();
- private volatile long thresholdTimeToPostponeUpdateMs =
TimeUnit.MINUTES.toMillis(1);
+ /* Contain dropped tables, can`t update statistic for such case. */
+ Set<Integer> droppedTables = Collections.newSetFromMap(new
ConcurrentHashMap<>());
+
+ private final ScheduledExecutorService scheduler;
+ private final StatisticAggregator<Collection<InternalTable>,
CompletableFuture<Map<Integer, PartitionModificationInfo>>> statSupplier;
+
+ static final long INITIAL_DELAY = 5_000;
+ static final long REFRESH_PERIOD = 2_000; // !!!!
Review Comment:
Meaningless comment
```suggestion
static final long REFRESH_PERIOD = 2_000;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
